Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring PDF viz support to Julia #800

Merged
merged 2 commits into from
May 5, 2022
Merged

Bring PDF viz support to Julia #800

merged 2 commits into from
May 5, 2022

Conversation

jeremiahpslewis
Copy link
Contributor

@jeremiahpslewis jeremiahpslewis commented May 4, 2022 •
edited
Loading

Enable vector plot output for quarto PDF docs for Julia libraries CairoMakie.jl and Plots.jl

@jeremiahpslewis jeremiahpslewis mentioned this pull request May 4, 2022
Closed
@jeremiahpslewis jeremiahpslewis marked this pull request as ready for review May 4, 2022 21:43
@jeremiahpslewis
Copy link
Contributor Author

  • Tested locally, looks reasonable for Plots and CairoMakie.
  • Shifted from using Plots to import Plots to handle namespace conflicts, user can add a using Plots as needed

jjallaire
jjallaire reviewed May 4, 2022
View reviewed changes
src/resources/jupyter/lang/julia/setup.jl
if fig_format == :retina
fig_format = :svg
elseif fig_format == :pdf
fig_dpi = 96
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the DPI to be left alone here? (we default it to 300 for PDF, we defaulted it back to 96 only b/c we were re-routing to PNG)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that we need the dpi to be 96 for the pixel calculation to be correct

@jjallaire
Copy link
Collaborator

I'll go ahead and merge this notwithstanding the comments about dpi (I'll assume you'll come back with a different PR if you think some adjustment in how we handle dpi for PDF is warranted)

@jjallaire jjallaire merged commit be2e8b7 into quarto-dev:main May 5, 2022
@jeremiahpslewis jeremiahpslewis deleted the patch-1 branch May 5, 2022 06:30
@jjallaire
Copy link
Collaborator

Hi there @jeremiahpslewis, posting back here because I'm giving a talk on Quarto at JuliaCon next month and was hoping to find some good examples of using Julia w/ Quarto. If you are able to share any of your own (or are aware of others) please LMK over on this discussion thread: #1261. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjallaire jjallaire jjallaire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiahpslewis @jjallaire