Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backgroundSize property to uploader #17494

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

jrking4
Copy link
Contributor

@jrking4 jrking4 commented Sep 6, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
The current uploader thumbnails only show the images in "cover" mode. This shows a fraction of the image preview. This PR adds the ability to set a custom CSS background size for the thumbnail images, while defaulting to the current behavior.

@rstoenescu rstoenescu merged commit 740c2f9 into quasarframework:dev Sep 9, 2024
@rstoenescu
Copy link
Member

Thanks for contributing!
Will make some slight changes. This will go into Quasar v2.16.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants