Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in types.Identical rule #95

Merged
merged 1 commit into from
Oct 23, 2020
Merged

fix bug in types.Identical rule #95

merged 1 commit into from
Oct 23, 2020

Conversation

orsinium
Copy link
Contributor

False-positive:

$ ruleguard.bin -rules rules.go go/... 
/usr/local/go/src/go/internal/gcimporter/bimport.go:241:35: suspicious duplicated args in types.Identical(a.Type(), b.Type())

@quasilyte quasilyte merged commit 4d26bb9 into quasilyte:master Oct 23, 2020
@orsinium orsinium deleted the fix-rule-1 branch October 23, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orsinium @quasilyte