-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_choice
to test entry in list
#102
Conversation
This PR is opened without any actual |
pan/functions.pan
Outdated
# Merge the arguments into the given array. Neither the | ||
# first/next or merge functions can be used because the | ||
# ARGV array cannot be directly referenced. | ||
# Cannot use merge or refernce ARGV directly | ||
i = 0; | ||
while (i<ARGC) { | ||
v[length(v)] = ARGV[i]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be replaced with append(ARGV[i]) ? That's what I deployed to our code base internally recently.
@ned21 from the comments in the old code, it looked that what release of panc can we use to release the core templates? |
pan/functions.pan
Outdated
function full_hostname_from_object = { | ||
# Check cardinality; leave detailed error checking to called functions. | ||
if (ARGC != 1) error("usage: full_hostname_from_object(default_domain)"); | ||
if (ARGC != 1) error("usage: full_hostname_from_object(default_domain) requires default_domian as argument"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default domian -> default domain
@stdweird about |
pan/functions.pan
Outdated
############################################################ | ||
@documentation{ | ||
pushes zero of more pairs (key, value) into a | ||
dict. If the list does not exist or is not defined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/list/dict/ in this line
Any good reason for this PR not to be merged yet... Would be good to have in 16.10 so that we can start using it,.. |
this PR is completely irrelevant if someone could be bothered to review merge quattor/pan#121 and quattor/pan#125 ... |
Those two PRs are now merged, so this probably needs reworking. |
@stdweird is this now irrelevant? |
@stdweird ping? |
Use case is in schema files to use
instead of current
with match(SELF, ''^(a|b|c)$")
(and it also allows
string[] with is_choice(...)
transparently)