Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout option in connection wrapper (#119) #336

Open
wants to merge 1 commit into
base: unreleased
Choose a base branch
from

Conversation

choeh
Copy link

@choeh choeh commented May 3, 2021

I have faced the same issue that was mentioned in #119 .

The default 300 seconds as timeout for connections to QDS was not big enough to run commands for heavy load SQL queries against QDS.

This PR enables users to specify their custom timeout value as a parameter and removes the hardcoded default value from the SDK. It furthermore helps overcome the HTTPSConnectionPool(host='qubole.com', port=443): Read timed out. (read timeout=300) error raised by requests.exceptions.Timeout when commands do not finish before the default 300s.

@choeh
Copy link
Author

choeh commented May 3, 2021

I just saw last commit is months ago... Do you think this can be merged in the shortterm and not in months @SandeepBelagavi, @chattarajoy, @akaranjkar-qu ? I highly appreciate a short response from anybody on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant