Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support iperf-style intermittent results #17

Merged
merged 6 commits into from
Oct 19, 2023
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 51 additions & 2 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ import (
)

type Result struct {
Latency float64 `json:"latency"`
Type string `json:"type"`
TimeSeconds float64 `json:"timeSeconds"`
UploadBytes uint `json:"uploadBytes"`
DownloadBytes uint `json:"downloadBytes"`
mxinden marked this conversation as resolved.
Show resolved Hide resolved
}

func RunClient(addr string, uploadBytes, downloadBytes uint64, keyLogFile io.Writer) error {
Expand Down Expand Up @@ -45,7 +48,10 @@ func RunClient(addr string, uploadBytes, downloadBytes uint64, keyLogFile io.Wri
log.Printf("uploaded %s: %.2fs (%s/s)", formatBytes(uploadBytes), uploadTook.Seconds(), formatBytes(bandwidth(uploadBytes, uploadTook)))
log.Printf("downloaded %s: %.2fs (%s/s)", formatBytes(downloadBytes), downloadTook.Seconds(), formatBytes(bandwidth(downloadBytes, downloadTook)))
json, err := json.Marshal(Result{
Latency: time.Since(start).Seconds(),
TimeSeconds: time.Since(start).Seconds(),
Type: "final",
UploadBytes: uint(uploadBytes),
DownloadBytes: uint(downloadBytes),
})
if err != nil {
return err
Expand All @@ -64,7 +70,27 @@ func handleClientStream(str io.ReadWriteCloser, uploadBytes, downloadBytes uint6
// upload data
b = make([]byte, 16*1024)
uploadStart := time.Now()

lastReportTime := time.Now()
lastReportWrite := 0
mxinden marked this conversation as resolved.
Show resolved Hide resolved

for uploadBytes > 0 {
now := time.Now()
if now.Sub(lastReportTime) > time.Second {
mxinden marked this conversation as resolved.
Show resolved Hide resolved
jsonB, err := json.Marshal(Result{
TimeSeconds: now.Sub(lastReportTime).Seconds(),
UploadBytes: uint(lastReportWrite),
Type: "intermediary",
})
if err != nil {
log.Fatalf("failed to marshal perf result: %s", err)
}
fmt.Println(string(jsonB))

lastReportTime = now
lastReportWrite = 0
}

if uploadBytes < uint64(len(b)) {
b = b[:uploadBytes]
}
Expand All @@ -73,7 +99,9 @@ func handleClientStream(str io.ReadWriteCloser, uploadBytes, downloadBytes uint6
return 0, 0, err
}
uploadBytes -= uint64(n)
lastReportWrite += n
}

if err := str.Close(); err != nil {
return 0, 0, err
}
Expand All @@ -83,12 +111,33 @@ func handleClientStream(str io.ReadWriteCloser, uploadBytes, downloadBytes uint6
b = b[:cap(b)]
remaining := downloadBytes
downloadStart := time.Now()

lastReportTime = time.Now()
lastReportRead := 0
mxinden marked this conversation as resolved.
Show resolved Hide resolved

for remaining > 0 {
now := time.Now()
if now.Sub(lastReportTime) > time.Second {
mxinden marked this conversation as resolved.
Show resolved Hide resolved
jsonB, err := json.Marshal(Result{
TimeSeconds: now.Sub(lastReportTime).Seconds(),
DownloadBytes: uint(lastReportRead),
Type: "intermediary",
})
if err != nil {
log.Fatalf("failed to marshal perf result: %s", err)
}
fmt.Println(string(jsonB))

lastReportTime = now
lastReportRead = 0
}

n, err := str.Read(b)
if uint64(n) > remaining {
return 0, 0, fmt.Errorf("server sent more data than expected, expected %d, got %d", downloadBytes, remaining+uint64(n))
}
remaining -= uint64(n)
lastReportRead += n
if err != nil {
if err == io.EOF {
if remaining == 0 {
Expand Down