hkdf: move custom HKDF-Expand-Label implementation to a separate package #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4317 +/- ##
==========================================
+ Coverage 85.16% 85.17% +0.01%
==========================================
Files 151 151
Lines 14750 14750
==========================================
+ Hits 12561 12563 +2
+ Misses 1680 1679 -1
+ Partials 509 508 -1 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
hkdf-package
branch
from
e635501
to
117f0ff
Compare
marten-seemann
force-pushed
the
hkdf-package
branch
from
117f0ff
to
54dc03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to move the hkdf and hmac standard library packages here, and optimize them in terms of allocations. At some later point, we can upstream these changes into the standard library, should the Go team be interested in them.
Part of #3663.