Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more argument sanity checks for affine quantizer constructor #3307

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add more argument sanity checks for affine quantizer constructor #3307

merged 1 commit into from
Sep 3, 2024

Conversation

quic-kyunggeu
Copy link
Contributor 

>>> from aimet_torch.v2.quantization.affine import QuantizeDequantize
>>> QuantizeDequantize((), -128, 127, True, hello=None)
TypeError: QuantizeDequantize.__init__ got unexpected keyword argument: hello

@quic-kyunggeu
Add more argument sanity checks
a3c900f 
Signed-off-by: Kyunggeun Lee <[email protected]>
@quic-kyunggeu quic-kyunggeu self-assigned this Sep 3, 2024
@quic-kyunggeu quic-kyunggeu merged commit 66babf3 into quic:develop Sep 3, 2024
3 checks passed
@quic-kyunggeu quic-kyunggeu deleted the add_argument_sanity_check branch September 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quic-mtuttle quic-mtuttle quic-mtuttle approved these changes

@quic-akhobare quic-akhobare Awaiting requested review from quic-akhobare

Assignees

@quic-kyunggeu quic-kyunggeu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quic-kyunggeu @quic-mtuttle