Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GPTJ #5

Merged

Conversation

quic-mamta
Copy link
Contributor

@quic-mamta quic-mamta commented Apr 30, 2024

  1. Add modeling file changes to support GPTJ model based on new interface
  2. Clean up code in utils and modeling files

@quic-jhugo
Copy link
Contributor

Signed off by tag needs to be fixed.

@anujgupt-github anujgupt-github added enhancement New feature or request good first issue Good for newcomers labels May 3, 2024
@quic-mamta quic-mamta changed the title Add support for GPTJ model and unit tests Add support for GPTJ May 6, 2024
@anujgupt-github
Copy link
Contributor

Is this version of GPT-J going to support text generation or can support summarization (with beam search on device)?
If latter, KV$ is split between prefill KV and decode KV (xtimes beam)

Signed-off-by: mamtsing <[email protected]>
Signed-off-by: mamtsing <[email protected]>
@quic-mamta quic-mamta force-pushed the add_gptj_modeling_files_and_unit_tests branch from 1ed1a3c to 2a6853d Compare May 17, 2024 15:43
@vbaddi
Copy link
Contributor

vbaddi commented Jun 13, 2024

@quic-mamta , can you make this based on new interface changes pls?

QEfficient/transformers/modeling_utils.py Outdated Show resolved Hide resolved
QEfficient/transformers/models/gptj/modeling_gptj.py Outdated Show resolved Hide resolved
QEfficient/transformers/models/gptj/modeling_gptj.py Outdated Show resolved Hide resolved
quic-mamta and others added 7 commits June 17, 2024 12:25
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
@quic-mamta quic-mamta self-assigned this Jun 18, 2024
Copy link
Contributor

@vbaddi vbaddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

QEfficient/transformers/models/gptj/modeling_gptj.py Outdated Show resolved Hide resolved
QEfficient/transformers/models/gptj/modeling_gptj.py Outdated Show resolved Hide resolved
QEfficient/utils/generate_inputs.py Outdated Show resolved Hide resolved
QEfficient/utils/generate_inputs.py Outdated Show resolved Hide resolved
Copy link
Contributor

@irajagop irajagop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quic-mamta quic-mamta merged commit ef6d68b into quic:main Jun 19, 2024
2 checks passed
abukhoy pushed a commit to abukhoy/efficient-transformers that referenced this pull request Jun 28, 2024
* Add support for GPTJ model and unit tests

Signed-off-by: mamtsing <[email protected]>
Signed-off-by: mamtsing <[email protected]>

* Update modeling file to support GPTJ model based on new interface

Signed-off-by: mamtsing <[email protected]>

* Update modeling_gptj.py

Signed-off-by: Mamta Singh <[email protected]>

* Update generate_inputs.py

Signed-off-by: Mamta Singh <[email protected]>

* Update run_utils.py

Signed-off-by: Mamta Singh <[email protected]>

* Update generate_inputs.py

Signed-off-by: Mamta Singh <[email protected]>

* Update config.json

Signed-off-by: Mamta Singh <[email protected]>

* Update class comments

Signed-off-by: Mamta Singh <[email protected]>

* Update _utils.py

Signed-off-by: Mamta Singh <[email protected]>

* Update _utils.py

Signed-off-by: Mamta Singh <[email protected]>

* Update modeling_gptj.py

Signed-off-by: Mamta Singh <[email protected]>

* Update config.json

Signed-off-by: Mamta Singh <[email protected]>

* Update modeling_gptj.py

Signed-off-by: Mamta Singh <[email protected]>

* Update generate_inputs.py

Signed-off-by: Mamta Singh <[email protected]>

---------

Signed-off-by: mamtsing <[email protected]>
Signed-off-by: mamtsing <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>

Signed-off-by: root <[email protected]>
shubhagr-quic pushed a commit to shubhagr-quic/efficient-transformers that referenced this pull request Oct 4, 2024
* Add support for GPTJ model and unit tests

Signed-off-by: mamtsing <[email protected]>
Signed-off-by: mamtsing <[email protected]>

* Update modeling file to support GPTJ model based on new interface

Signed-off-by: mamtsing <[email protected]>

* Update modeling_gptj.py

Signed-off-by: Mamta Singh <[email protected]>

* Update generate_inputs.py

Signed-off-by: Mamta Singh <[email protected]>

* Update run_utils.py

Signed-off-by: Mamta Singh <[email protected]>

* Update generate_inputs.py

Signed-off-by: Mamta Singh <[email protected]>

* Update config.json

Signed-off-by: Mamta Singh <[email protected]>

* Update class comments

Signed-off-by: Mamta Singh <[email protected]>

* Update _utils.py

Signed-off-by: Mamta Singh <[email protected]>

* Update _utils.py

Signed-off-by: Mamta Singh <[email protected]>

* Update modeling_gptj.py

Signed-off-by: Mamta Singh <[email protected]>

* Update config.json

Signed-off-by: Mamta Singh <[email protected]>

* Update modeling_gptj.py

Signed-off-by: Mamta Singh <[email protected]>

* Update generate_inputs.py

Signed-off-by: Mamta Singh <[email protected]>

---------

Signed-off-by: mamtsing <[email protected]>
Signed-off-by: mamtsing <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants