Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor custom ops into proper file locations #55

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

irajagop
Copy link
Contributor

@irajagop irajagop commented Jun 27, 2024

Create proper files for custom ops instead of putting them all in __init__.py. Added import in __init__.py so existing code is not affected.

Copy link
Contributor

@vbaddi vbaddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@ochougul
Copy link
Contributor

Please rebase with main.

@ochougul ochougul merged commit 8265edf into main Jul 10, 2024
4 checks passed
@irajagop irajagop deleted the custom_ops_refactor branch July 11, 2024 07:04
quic-rishinr pushed a commit to quic-rishinr/efficient-transformers that referenced this pull request Jul 16, 2024
* Refactor custom ops into proper file locations

Signed-off-by: Ilango Rajagopal <[email protected]>

* Remove the old native RMSNorm code

Signed-off-by: Ilango Rajagopal <[email protected]>

---------

Signed-off-by: Ilango Rajagopal <[email protected]>
shubhagr-quic pushed a commit to shubhagr-quic/efficient-transformers that referenced this pull request Oct 4, 2024
* Refactor custom ops into proper file locations

Signed-off-by: Ilango Rajagopal <[email protected]>

* Remove the old native RMSNorm code

Signed-off-by: Ilango Rajagopal <[email protected]>

---------

Signed-off-by: Ilango Rajagopal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants