-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor custom ops into proper file locations #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irajagop
force-pushed
the
custom_ops_refactor
branch
from
June 27, 2024 11:44
1081625
to
6f93c4c
Compare
irajagop
force-pushed
the
custom_ops_refactor
branch
from
June 27, 2024 12:00
7d98823
to
da8ef70
Compare
irajagop
force-pushed
the
custom_ops_refactor
branch
from
July 1, 2024 11:18
da8ef70
to
e4af288
Compare
ochougul
reviewed
Jul 4, 2024
ochougul
reviewed
Jul 4, 2024
ochougul
reviewed
Jul 4, 2024
irajagop
force-pushed
the
custom_ops_refactor
branch
from
July 9, 2024 12:40
e4af288
to
0b19593
Compare
vbaddi
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
ochougul
approved these changes
Jul 10, 2024
Please rebase with main. |
Signed-off-by: Ilango Rajagopal <[email protected]>
Signed-off-by: Ilango Rajagopal <[email protected]>
irajagop
force-pushed
the
custom_ops_refactor
branch
from
July 10, 2024 08:28
0b19593
to
6623341
Compare
quic-rishinr
pushed a commit
to quic-rishinr/efficient-transformers
that referenced
this pull request
Jul 16, 2024
* Refactor custom ops into proper file locations Signed-off-by: Ilango Rajagopal <[email protected]> * Remove the old native RMSNorm code Signed-off-by: Ilango Rajagopal <[email protected]> --------- Signed-off-by: Ilango Rajagopal <[email protected]>
shubhagr-quic
pushed a commit
to shubhagr-quic/efficient-transformers
that referenced
this pull request
Oct 4, 2024
* Refactor custom ops into proper file locations Signed-off-by: Ilango Rajagopal <[email protected]> * Remove the old native RMSNorm code Signed-off-by: Ilango Rajagopal <[email protected]> --------- Signed-off-by: Ilango Rajagopal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create proper files for custom ops instead of putting them all in
__init__.py
. Added import in__init__.py
so existing code is not affected.