Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing assertions #98

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replacing assertions #98

wants to merge 3 commits into from
+48 −35

Conversation

quic-meet
Copy link

  • Replaced all assertion errors with suitable builtin python exceptions as mentioned by @quic-shagun

@ochougul
Copy link
Contributor

@irajagop please review

@ochougul
Copy link
Contributor

@quic-meet PR #116 will be closed first; you need to rebase and address comments after that.

quic-meet and others added 2 commits October 8, 2024 02:35
@quic-meet
Replacing assertions
de96097 
Signed-off-by: quic-meet <[email protected]>
Changes
983af26 
Signed-off-by: Meet Doshi <[email protected]>
misisng device ids param
3dc45ff 
Signed-off-by: Meet Doshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochougul ochougul ochougul left review comments

@quic-rishinr quic-rishinr Awaiting requested review from quic-rishinr quic-rishinr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quic-meet @ochougul