Cherry-pick of a few bugfixes made since dec-2023 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guest error is sufficient. A debugger could read this and kill the emulation. Signed-off-by: Sid Manning <[email protected]>
`frameket = r0` before:
0x000070e0: 0x6220c011 { C17/pmucnt1 = R0 }
And after:
0x000070e0: 0x6220c011 { C17/framekey = R0 }
Signed-off-by: Matheus Tavares Bernardino <[email protected]>
The comment above the fCHECK_PCALIGN macro mentions the need to implement this check at all the COF instructions, but it is also a bit outdated since the macro is not in use anymore. Remove it and properly implement the check at gen_write_new_pc_addr(). Also add a test. Signed-off-by: Matheus Tavares Bernardino <[email protected]>
The implementation for these instructions is handling -0 as an invalid float point value, whereas the Hexagon hardware considers it the same as +0 (which is valid). Let's fix that and add a regression test. Signed-off-by: Matheus Tavares Bernardino <[email protected]>
The added test shows a scenario in which multiple writes are performed to the same register but qemu fails to detect that and throw the appropriated exception. This happens because we are not cleaning hex_slot_cancelled as frequently as we should, so an old state is used and the packet that should raise an exception is considered as cancelled by the code that would detect the multiple writes issue. Let's fix that by cleaning hex_slot_canceled on all conditional instructions instead, which should cover all cases where the variable is used to detect multiple writes. Signed-off-by: Matheus Tavares Bernardino <[email protected]>
QEMU should throw an HEX_CAUSE_STACK_LIMIT exception (0x27) if allocframe would move sp beyond the framelimit. Also modernize test file and add more test cases for different scenarios (user/monitor mode, overflow/no-overflow). This was tested with and without idef-parser. Signed-off-by: Matheus Tavares Bernardino <[email protected]>
androm3da
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes only the patches that are easier to backport without requiring huge changes.