Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect parse of '(): RT<T>=> { throw ''; }' #1169

Closed
strager opened this issue Jan 7, 2024 · 1 comment · Fixed by #1175
Closed

incorrect parse of '(): RT<T>=> { throw ''; }' #1169

strager opened this issue Jan 7, 2024 · 1 comment · Fixed by #1175
Assignees
@vegerot
Labels
false positive Severe bug: quick-lint-js rejects valid code

Comments

@strager
Copy link
Collaborator

strager commented Jan 7, 2024

The following TypeScript code is parsed incorrectly by quick-lint-js:

class RT<X> {}
class T {}

let f = (): RT<T>=> { throw ''; };
@strager strager added the false positive Severe bug: quick-lint-js rejects valid code label Jan 7, 2024
@strager strager added this to the 3.1 milestone Jan 7, 2024
@vegerot
Copy link
Contributor

vegerot commented Jan 7, 2024

I accept this task. (I’m an expert on parsing > btw)

vegerot added a commit to vegerot/quick-lint-js that referenced this issue Jan 8, 2024
@vegerot
fix(lex): parse let f = (): RT<T>=>null;
57e12bd 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes quick-lint#1169
@vegerot vegerot mentioned this issue Jan 8, 2024
Merged
vegerot added a commit to vegerot/quick-lint-js that referenced this issue Jan 8, 2024
@vegerot
fix(lex): parse let f = (): RT<T>=>null;
1e8190c 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes quick-lint#1169
vegerot added a commit to vegerot/quick-lint-js that referenced this issue Jan 8, 2024
@vegerot
fix(lex): parse let f = (): RT<T>=>null;
e076dd5 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes quick-lint#1169
@strager strager removed this from the 3.1 milestone Jan 11, 2024
vegerot added a commit to vegerot/quick-lint-js that referenced this issue Jan 13, 2024
@vegerot
fix(lex): parse let f = (): RT<T>=>null;
01a30d1 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes quick-lint#1169
vegerot added a commit to vegerot/quick-lint-js that referenced this issue Jan 15, 2024
@vegerot
fix(lex): parse let f = (): RT<T>=>null;
c2072c2 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes quick-lint#1169
vegerot added a commit to vegerot/quick-lint-js that referenced this issue Jan 15, 2024
@vegerot
fix(lex): parse let f = (): RT<T>=>null;
952e530 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes quick-lint#1169
strager pushed a commit that referenced this issue Jan 21, 2024
@vegerot @strager
fix(lex): parse let f = (): RT<T>=>null;
4f0952b 
Test Plan:
`let f = (): RT<T>=>null;`

Fixes #1169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegerot vegerot

Labels
false positive Severe bug: quick-lint-js rejects valid code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lex): parse let f = (): RT<T>=>null; vegerot/quick-lint-js
2 participants
@strager @vegerot