Windows-x86 flaky test failure: internal check failed in flush_impl: false

[strager]

https://github.com/quick-lint/quick-lint-js/actions/runs/3202094600/jobs/5230725143

test 1
    Start 1: quick-lint-js-test

1: Test command: D:\a\quick-lint-js\quick-lint-js\build\test\quick-lint-js-test.exe
1: Working Directory: D:/a/quick-lint-js/quick-lint-js/build/test
1: Test timeout computed to be: 1500
1: Running main() from gmock_main.cc
1: [==========] Running 1879 tests from 145 test suites.
1: [----------] Global test environment set-up.
1: [----------] 3 tests from test_write_integer
1: [ RUN      ] test_write_integer.common_integers
1: [       OK ] test_write_integer.common_integers (0 ms)
[snip]
1: [ RUN      ] typescript/test_parse_conditional_expression.conditional_expression_with_missing_colon_and_false_component/0
1: [       OK ] typescript/test_parse_conditional_expression.conditional_expression_with_missing_colon_and_false_component/0 (0 ms)
1: [----------] 5 tests from typescript/test_parse_conditional_expression (0 ms total)
1: 
1: [----------] Global test environment tear-down
1: [==========] 1879 tests from 145 test suites ran. (9726 ms total)
1: [  PASSED  ] 1879 tests.
1: 
1:   YOU HAVE 1 DISABLED TEST
1: 
1: D:/a/quick-lint-js/quick-lint-js/src/quick-lint-js/io/output-stream.cpp:101: internal check failed in flush_impl: false
1: quick-lint-js crashed. Please report this bug here:
1: https://quick-lint-js.com/crash-report/
1/2 Test #1: quick-lint-js-test ...............***Failed    9.77 sec

[strager]

Saw it again: https://github.com/quick-lint/quick-lint-js/actions/runs/3203555922/jobs/5233792532

[strager]

Release build failure: https://github.com/quick-lint/quick-lint-js/actions/runs/3212775439/jobs/5251931531

[strager]

More info: https://github.com/quick-lint/quick-lint-js/actions/runs/3233883823/jobs/5330148207

1: fatal: file_output_stream::flush_impl failed to write data: The handle is invalid.
1: D:\a\quick-lint-js\quick-lint-js\src\quick-lint-js\io\output-stream.cpp:106: internal check failed in flush_impl: false

[strager]

I'm 90% sure that file_output_stream::flush_impl is being called by the destructor for the stream static-storage-duration variable in file_output_stream::get_stderr. It's being called during process teardown, hence the crash happening after all tests pass.

this->file_ cannot be an invalid handle (NULL or INVALID_HANDLE_VALUE). If it was, the assertion at the beginning of windows_handle_file_ref::write_full would have failed.

My only hypothesis is that the stderr standard handle got closed during process teardown. I don't know why this would happen. Maybe Microsoft's crt does this? But why?

I know two ways to accidentally fix this bug (but not fix the root cause):

1. Make output_stream::flush not call flush_impl if there is no data to write, or
2. Make parse_and_lint call file_output_stream::get_stderr only if options.print_parser_visits is true.

[strager]

Fixed in commit d910d71.