-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows-x86 flaky test failure: internal check failed in flush_impl: false #859
Comments
Release build failure: https://github.com/quick-lint/quick-lint-js/actions/runs/3212775439/jobs/5251931531 |
Tests are flaky on Windows [1]. Here's what I see on CI when a failure happens: [snip] 1: [----------] 5 tests from typescript/test_parse_conditional_expression (0 ms total) 1: 1: [----------] Global test environment tear-down 1: [==========] 1879 tests from 145 test suites ran. (9726 ms total) 1: [ PASSED ] 1879 tests. 1: 1: YOU HAVE 1 DISABLED TEST 1: 1: D:/a/quick-lint-js/quick-lint-js/src/quick-lint-js/io/output-stream.cpp:101: internal check failed in flush_impl: false 1: quick-lint-js crashed. Please report this bug here: 1: https://quick-lint-js.com/crash-report/ 1/2 Test #1: quick-lint-js-test ...............***Failed 9.77 sec Add some debug logs to help isolate the bug. [1] #859
Tests are flaky on Windows [1]. Here's what I see on CI when a failure happens: [snip] 1: [----------] 5 tests from typescript/test_parse_conditional_expression (0 ms total) 1: 1: [----------] Global test environment tear-down 1: [==========] 1879 tests from 145 test suites ran. (9726 ms total) 1: [ PASSED ] 1879 tests. 1: 1: YOU HAVE 1 DISABLED TEST 1: 1: D:/a/quick-lint-js/quick-lint-js/src/quick-lint-js/io/output-stream.cpp:101: internal check failed in flush_impl: false 1: quick-lint-js crashed. Please report this bug here: 1: https://quick-lint-js.com/crash-report/ 1/2 Test #1: quick-lint-js-test ...............***Failed 9.77 sec Add some debug logs to help isolate the bug. [1] #859
Tests are flaky on Windows [1]. Here's what I see on CI when a failure happens: [snip] 1: [----------] 5 tests from typescript/test_parse_conditional_expression (0 ms total) 1: 1: [----------] Global test environment tear-down 1: [==========] 1879 tests from 145 test suites ran. (9726 ms total) 1: [ PASSED ] 1879 tests. 1: 1: YOU HAVE 1 DISABLED TEST 1: 1: D:/a/quick-lint-js/quick-lint-js/src/quick-lint-js/io/output-stream.cpp:101: internal check failed in flush_impl: false 1: quick-lint-js crashed. Please report this bug here: 1: https://quick-lint-js.com/crash-report/ 1/2 Test #1: quick-lint-js-test ...............***Failed 9.77 sec Add some debug logs to help isolate the bug. [1] #859
Tests are flaky on Windows [1]. Here's what I see on CI when a failure happens: [snip] 1: [----------] 5 tests from typescript/test_parse_conditional_expression (0 ms total) 1: 1: [----------] Global test environment tear-down 1: [==========] 1879 tests from 145 test suites ran. (9726 ms total) 1: [ PASSED ] 1879 tests. 1: 1: YOU HAVE 1 DISABLED TEST 1: 1: D:/a/quick-lint-js/quick-lint-js/src/quick-lint-js/io/output-stream.cpp:101: internal check failed in flush_impl: false 1: quick-lint-js crashed. Please report this bug here: 1: https://quick-lint-js.com/crash-report/ 1/2 Test #1: quick-lint-js-test ...............***Failed 9.77 sec Add some debug logs to help isolate the bug. [1] #859
More info: https://github.com/quick-lint/quick-lint-js/actions/runs/3233883823/jobs/5330148207
|
I'm 90% sure that
My only hypothesis is that the stderr standard handle got closed during process teardown. I don't know why this would happen. Maybe Microsoft's crt does this? But why? I know two ways to accidentally fix this bug (but not fix the root cause):
|
Fixed in commit d910d71. |
https://github.com/quick-lint/quick-lint-js/actions/runs/3202094600/jobs/5230725143
The text was updated successfully, but these errors were encountered: