feat: error on 'for await' in non-async function #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarocque
force-pushed
the
for-await-non-async-function
branch
from
cae93d8
to
876623e
Compare
|
@strager Do you know why the macOS AArch64 build is failing, or how I might be able to fix it? I don't see how my changes would cause the builds to fail, and I can't find any output from the failing checks. |
Those jobs run on my machine in my home lab, and the machine was turned off. 🙃 It should be fixed now. |
strager
requested changes
Jan 9, 2024
Added diagnostic when a 'for await' statement is in a non-async function, since this statement can only be used in contexts where 'await' can be used. closes quick-lint#1137
dlarocque
force-pushed
the
for-await-non-async-function
branch
from
876623e
to
3635fa9
Compare
strager
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added diagnostic when a 'for await' statement is in a non-async function, since this statement can only be used in contexts where 'await' can be used.
closes #1137