Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sonarLint to the table and updated the RSLint Rules link #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added sonarLint to the table and updated the RSLint Rules link #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9da3cb0
added sonarLint to the table and updated the RSLint Rules link
Xanas1252 Jun 11, 2021
fafd94d
fully completed the table
Xanas1252 Jun 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions website/public/index.ejs.html
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<th><a href="https://rslint.org/">RSLint</a></th>
<th><a href="https://deno.land/">Deno</a></th>
<th><a href="https://rome.tools/">Rome</a></th>
<th><a href="https://sonarlint.org/">SonarLint</a></th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks really wide. We could use &shy; to hyphenate "SonarLint" as "Sonar-Lint" to reduce the table width:

Suggested change
<th><a href="https://sonarlint.org/">SonarLint</a></th>
<th><a href="https://sonarlint.org/">Sonar&shy;Lint</a></th>

</tr>
</thead>
<tbody>
Expand Down Expand Up @@ -236,6 +237,9 @@ <h2 id="linter-feature-comparison">Features</h2>
<span aria-labelledby="feature-speed-rome-slow">🐢</span
><br /><span id="feature-speed-rome-slow">slow</span>
</td>
<td class="unkown">
<span id="feature-speed-sonarlint-unkown">?</span>
</td>
</tr>
<tr>
<th colspan="2">license</th>
Expand All @@ -245,6 +249,8 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="meh">open source<br />MIT</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Add a cell for SonarLint for the speed column. Write "?" if you're unsure about the speed; we can fill it in later after we run benchmarks.

<td class="meh">open source<br />MIT</td>
<td class="meh">open source<br />MIT</td>
<td class="good">free<br />LGPL</td>

</tr>
<tr>
<th colspan="2">easy npm install</th>
Expand All @@ -267,6 +273,7 @@ <h2 id="linter-feature-comparison">Features</h2>
</td>
<td class="bad"><span aria-label="hard">❌</span></td>
<td class="good"><span aria-label="easy">✅</span></td>
<td class="bad"><span aria-label="hard">❌</span></td>
</tr>
<tr>
<th colspan="2">easy setup</th>
Expand All @@ -288,6 +295,9 @@ <h2 id="linter-feature-comparison">Features</h2>
<span aria-label="hard">❌</span><br />config or
<code>init</code>
</td>
<td class="good">
<span aria-label="easy">✅</span><br />zero config
</td>
</tr>
<tr>
<th colspan="2">JSX</th>
Expand Down Expand Up @@ -321,6 +331,7 @@ <h2 id="linter-feature-comparison">Features</h2>
</td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
</tr>
<tr>
<th colspan="2">TypeScript</th>
Expand Down Expand Up @@ -354,6 +365,7 @@ <h2 id="linter-feature-comparison">Features</h2>
</td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
</tr>

<tr>
Expand All @@ -375,6 +387,9 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="meh">
<a href="https://rome.tools/docs/lint/rules/">some</a>
</td>
<td class="meh">
<a href="https://rules.sonarsource.com/javascript/type/Bug">some</a>
</td>
</tr>
<tr>
<th colspan="2">stable</th>
Expand All @@ -386,6 +401,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="unstable">❌</span></td>
<td class="good"><span aria-label="stable">✅</span></td>
<td class="bad"><span aria-label="unstable">❌</span></td>
<td class="good"><span aria-label="stable">✅</span></td>
</tr>
</tbody>

Expand All @@ -398,6 +414,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<th><a href="https://rslint.org/">RSLint</a></th>
<th><a href="https://deno.land/">Deno</a></th>
<th><a href="https://rome.tools/">Rome</a></th>
<th><a href="https://sonarlint.org/">SonarLint</a></th>
</tr>
<tr>
<th>VS Code</th>
Expand All @@ -410,6 +427,8 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>

</tr>
<tr>
<th>Vim</th>
Expand All @@ -422,6 +441,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
</tr>
<tr>
<th>WebStorm</th>
Expand All @@ -432,6 +452,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: SonarLint's website claims it has an IntelliJ (aka WebStorm) plugin. Does it not work for JS code? https://www.sonarlint.org/intellij/

</tr>
<tr>
<th>Sublime Text</th>
Expand All @@ -442,6 +463,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
</tr>
<tr>
<th>Notepad++</th>
Expand All @@ -455,6 +477,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
</tr>
<tr>
<th>Atom</th>
Expand All @@ -465,6 +488,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
</tr>
<tr>
<th>Emacs</th>
Expand All @@ -475,6 +499,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
</tr>
<tr>
<th colspan="2">LSP server</th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Add missing cell for LSP server.

It looks like their VS Code plugin uses an LSP server, so I'd say ✅ for SonarLint+LSP.

Expand All @@ -486,6 +511,7 @@ <h2 id="linter-feature-comparison">Features</h2>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
<td class="bad"><span aria-label="no">❌</span></td>
<td class="good"><span aria-label="yes">✅</span></td>
</tr>
</tbody>
</table>
Expand Down