Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: quickget downloads .ociarchive files instead of .iso files for Fedora Atomic Editions #1502

Closed
azmodude opened this issue Nov 4, 2024 · 0 comments · Fixed by #1503
Closed

Comments

@azmodude
Copy link
Contributor

azmodude commented Nov 4, 2024

I confirm this bug has not already been reported
It was reported in #1257 and was (temporarily) fixed in #1362

Describe the bug
quickget downloads a .ociarchive image for Fedora Atomic Editions - resulting in a non-bootable VM.

To Reproduce

$ ./quickget Fedora 41 Silverblue
Downloading Fedora 41 Silverblue
- URL: https://mirror.dogado.de/fedora/linux/releases/41/Silverblue/x86_64/images/Fedora-Silverblue-41.1.4.ociarchive
#######                                                                                                                                                                                                                                                     [...]
$ ./quickget Fedora 40 Silverblue
Downloading Fedora 40 Silverblue
- URL: https://mirror.dogado.de/fedora/linux/releases/40/Silverblue/x86_64/images/Fedora-Silverblue-40.1.14.ociarchive
#                                                                                                                                                                                                                                                           [...]
$ ./quickget Fedora 40 Kinoite   
Downloading Fedora 40 Kinoite
- URL: https://mirror.23m.com/fedora/linux/releases/40/Kinoite/x86_64/images/Fedora-Kinoite-40.1.14.ociarchive
#                                                                
[...]

Expected behavior
An .iso file is downloaded to produce a bootable VM.


#1362 tried to fix the problem by checking for an empty .sha256 field - it seems like Fedora is producing these now for the .ociarchive builds.

[...]
{
  "version": "41",
  "arch": "x86_64",
  "link": "https://download.fedoraproject.org/pub/fedora/linux/releases/41/Kinoite/x86_64/images/Fedora-Kinoite-41.1.4.ociarchive",
  "variant": "Kinoite",
  "subvariant": "Kinoite",
  "sha256": "284a235a73171b94f3f5fe7893900628d31e9aa0a8cee915b595e57200987168",
  "size": "2850653184"
}

  "version": "41",
  "arch": "x86_64",
  "link": "https://download.fedoraproject.org/pub/fedora/linux/releases/41/Kinoite/x86_64/iso/Fedora-Kinoite-ostree-x86_64-41-1.4.iso",
  "variant": "Kinoite",
  "subvariant": "Kinoite",
  "sha256": "2564128747a62dc642409c1e52f60d281c853069b1833e9c85d6abce4b3cd89d",
  "size": "3752888320"
}

Since the .ociarchive is provided in front of the .iso, quickget always gets the wrong .ociarchive.

azmodude added a commit to azmodude/quickemu that referenced this issue Nov 5, 2024
Also remove the SHA256 requirement. Fedora provides these for all links
now.
Fixes quickemu-project#1502
lj3954 added a commit that referenced this issue Nov 8, 2024
#1503)

* fix(fedora): Check whether the link value contains an actual .iso file

Also remove the SHA256 requirement. Fedora provides these for all links
now.
Fixes #1502

* refactor(fedora): Use more concise function to filter out non-ISO files

---------

Co-authored-by: Liam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant