Adjusted check values #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
criadoperez
commented
Aug 16, 2023
criadoperez
commented
- Code comment said it wouldn't install lobster testing with less than 18G but code was actually 32G
- Comment said minimum requirement was 50GB for abroot but code ia applying 64GB
- A few typos
philclifford
added a commit
to philclifford/quickemu-docs
that referenced
this pull request
Aug 29, 2023
taken from quickemu-project/quickemu#735 Co-authored-by: criadoperez <[email protected]>
philclifford
added a commit
to philclifford/quickemu-docs
that referenced
this pull request
Aug 29, 2023
taken from quickemu-project/quickemu#735 Co-authored-by: criadoperez <[email protected]>
philclifford
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Changes to the documentation are included in a merged PR to the documentation sub-module. (philclifford/quickemu-docs#12). The future regenerations will include them) if future document update PRs.
The minima mentioned in comments are the actual minima and intentionally do not reflect the headroom implemented to give users some space for usability.
Thanks for fixing the typos that sneaked through!
philclifford
approved these changes
Aug 30, 2023
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Sep 14, 2023
quickemu-project#735 Co-authored-by: Alejandro <[email protected]>
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Sep 16, 2023
quickemu-project#735 Co-authored-by: Alejandro <[email protected]>
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Sep 16, 2023
quickemu-project#735 Co-authored-by: Alejandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.