Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ—οΈ Lint PRs + OS pack πŸ¦₯ 1 #911

Closed
wants to merge 26 commits into from

Conversation

zen0bit
Copy link
Contributor

@zen0bit zen0bit commented Jan 19, 2024

Included:

πŸ—οΈ Lint PRs
πŸ“¦ Artix Linux - First time in #758 - πŸš₯
πŸ“¦ Athena OS - in #750 - πŸš₯
πŸ“¦ bazzite - in #797
πŸ“¦ Big Linux Thanks to @ruscher - in #748
πŸ›  BlendOS releases on 1 line
πŸ“¦ Chimera Linux - in #781
πŸ“¦ Crunchbang++ - in #881
πŸš‘ EasyOS fix and new releases - in #924 fix #921
πŸŒ€ EndeavourOS dynamic releases Thanks to @lj3954 - in #907
πŸ›  Gentoo livegui - in #905
πŸ“¦ Guix - in #768
πŸ“¦ Nitrux - in #873
πŸ“¦ Parrot Security - in #893
πŸ“¦ Primtux Thanks to @DaffyDuke - in #887
πŸ“¦ Slax - in #761
πŸ“¦ Slint - in #889
πŸ“¦ Slitaz GNU/Linux - in #664 - πŸš₯
πŸ“¦ SparkyLinux - in #799
πŸ›  spiral rename
πŸ›  ️Zorin 17 - in #880

  • picture legend
    πŸš₯ = Allready approved by @flexiondotorg
    πŸ—οΈ = workflow
    πŸ“¦ = new OS
    πŸ›  = changed OS
    πŸš‘ = fix bug
    πŸŒ€ = dynamic parsing

@zen0bit zen0bit force-pushed the os_pack_1 branch 3 times, most recently from 5a517f5 to 49e0454 Compare January 19, 2024 14:48
@zen0bit zen0bit changed the title Lint PRs + OS pack 1 πŸ—οΈ Lint PRs + πŸ¦₯ OS pack 1 Jan 19, 2024
@zen0bit zen0bit changed the title πŸ—οΈ Lint PRs + πŸ¦₯ OS pack 1 πŸ—οΈ Lint PRs + πŸ¦₯ OS pack 1 Jan 19, 2024
@zen0bit zen0bit changed the title πŸ—οΈ Lint PRs + πŸ¦₯ OS pack 1 πŸ—οΈ Lint PRs + OS pack πŸ¦₯ 1 Jan 19, 2024
@zen0bit zen0bit force-pushed the os_pack_1 branch 3 times, most recently from d030313 to 1b101db Compare January 19, 2024 15:54
@zen0bit zen0bit force-pushed the os_pack_1 branch 2 times, most recently from 89df458 to ed39b98 Compare January 20, 2024 09:07
@lj3954
Copy link
Member

lj3954 commented Jan 20, 2024

Once again, you need to test the changes you make. Echoing a variable with quotation marks preserves new lines and other special characters. The releases and editions functions are supposed to separate entries with spaces, not new lines. If you insist on "fixing" incorrect ShellCheck errors, you must replace new lines with spaces in another way, such as by piping the output to tr '\n' ' '.

@DidierSpaier
Copy link

DidierSpaier commented Jan 29, 2024

I recommend to remove " 14.2.1" at end of line 880 as this Slint release is no more supported, so won't receive security fixes any more.

@zen0bit
Copy link
Contributor Author

zen0bit commented Feb 10, 2024

Once again, you need to test the changes you make. Echoing a variable with quotation marks preserves new lines and other special characters. The releases and editions functions are supposed to separate entries with spaces, not new lines. If you insist on "fixing" incorrect ShellCheck errors, you must replace new lines with spaces in another way, such as by piping the output to tr '\n' ' '.

I don't have to. I am creating github action to check for me, if I don't broke something πŸ˜‰

error
You see?

@zen0bit
Copy link
Contributor Author

zen0bit commented Feb 10, 2024

I recommend to remove " 14.2.1" at end of line 880 as this Slint release is no more supported, so won't receive security fixes any more.

Bit forgot, but done now...

@zen0bit zen0bit mentioned this pull request Apr 11, 2024
@flexiondotorg
Copy link
Member

Closed via #986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easyos will not boot
6 participants