Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Extensions appear on applications #2970

Open
3 tasks done
skurfer opened this issue Sep 29, 2023 · 4 comments
Open
3 tasks done

[Bug]: Extensions appear on applications #2970

skurfer opened this issue Sep 29, 2023 · 4 comments
Assignees
Labels

Comments

@skurfer
Copy link
Member

skurfer commented Sep 29, 2023

Before submitting your bug report, please confirm you have completed the following steps

Bug description

After installing 2.4.1, a few applications in the catalog were showing up with the .app extension. At this point, they all show it.

I’m looking through the diff between 2.4.0 and 2.4.1 to see if I can figure out what happened, but if someone who worked on it has any immediate theories, feel free to chime in.

Steps to reproduce

  1. Invoke Quicksilver
  2. Search for an application

Expected behavior

the name of the application will appear without .app. I forget if this respects the Finder preference for extensions or not. All I know is I didn’t see them before and now I do.

MacOS Version

Other

Quicksilver Version

2.4.1

Relevant Plugins

No response

Crash Logs or Spindump

No response

Screenshots

Screenshot 2023-09-29 at 4 35 01 PM

Additional info

No response

@skurfer skurfer added the Visual label Sep 29, 2023
@skurfer skurfer self-assigned this Sep 29, 2023
@n8henrie
Copy link
Member

I wouldn't be surprised if it was my commit here: 260eee3

Might be a good place to start looking at least.

@n8henrie
Copy link
Member

I've reverted that commit here -- wanted to see if that fixes it?

@skurfer
Copy link
Member Author

skurfer commented Oct 2, 2023

That doesn’t seem to be it. I’ll revert back to 2.4.0 for a minute to make sure I’m not crazy.

Confirmed: I don’t see extensions for any apps under 2.4.0. I might have time to look at this tonight.

@pjrobertson
Copy link
Member

pjrobertson commented Dec 2, 2023

I knew it'd be me 🙈

f8d685ebab56345b5ee034a4b11bd8631b145e7b is the first bad commit
commit f8d685ebab56345b5ee034a4b11bd8631b145e7b
Author: Patrick Robertson
Date:   Sun Aug 20 14:41:32 2023 +0800

f8d685e

Looking into it now

pjrobertson added a commit that referenced this issue Dec 2, 2023
Fixes issue #2970

Note: This *re-introduces the bug fixed in #2917 - that bug is actually a Finder issue and not a QS issue
pjrobertson added a commit that referenced this issue Dec 2, 2023
Fixes issue #2970

Note: This *re-introduces the bug fixed in #2917 - that bug is actually a Finder issue and not a QS issue
n8henrie pushed a commit that referenced this issue Dec 3, 2023
Fixes issue #2970

Note: This *re-introduces the bug fixed in #2917 - that bug is actually a Finder issue and not a QS issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants