Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge CLI command. #2149

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Fix merge CLI command. #2149

merged 4 commits into from
Oct 21, 2022

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Oct 19, 2022

Fix #2062 and partially #1981

Partially because the logs end up like this:

2022-10-19T18:45:18.936Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=IndexingPipeline-twilight-8Ygs exit_status=Success
2022-10-19T18:45:18.938Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=quickwit_indexing::actors::indexing_service::IndexingService-blue-Swh0 exit_status=Quit
2022-10-19T18:45:18.938Z ERROR quickwit_actors::actor: actor-failure actor_name="quickwit_indexing::actors::indexing_service::IndexingService-blue-Swh0" actor_exit_status=Quit
2022-10-19T18:45:19.939Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=Scheduler-icy-gsOt exit_status=Killed
2022-10-19T18:45:19.939Z ERROR quickwit_actors::actor: actor-failure actor_name="Scheduler-icy-gsOt" actor_exit_status=Killed

We don't want ERROR logs when everything goes well. I think we should not print an ERROR on an "actor_handle.quit()".

I opened an issue to see what we can do on that #2150.

quickwit/quickwit-cli/src/index.rs Outdated Show resolved Hide resolved
quickwit/quickwit-cli/src/index.rs Show resolved Hide resolved
quickwit/quickwit-cli/src/index.rs Outdated Show resolved Hide resolved
quickwit/quickwit-cli/src/index.rs Show resolved Hide resolved
quickwit/quickwit-cli/src/index.rs Outdated Show resolved Hide resolved
@fmassot fmassot merged commit 8fbc975 into main Oct 21, 2022
@fmassot fmassot deleted the fmassot--fix-merge-cli branch October 21, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspect code smell
2 participants