Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store instrumentation scope #2687

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Store instrumentation scope #2687

merged 1 commit into from
Jan 20, 2023

Conversation

guilload
Copy link
Member

Description

This scope contains the collector name and version.

How was this PR tested?

Deleted trace index and ran:

QW_ENABLE_JAEGER_SERVICE=true \
QW_ENABLE_OPENTELEMETRY_OTLP_EXPORTER=true \
QW_ENABLE_OPENTELEMETRY_OTLP_SERVICE=true \
OTEL_EXPORTER_OTLP_ENDPOINT=http://127.0.0.1:7281 \
RUST_BACKTRACE=1 \
RUST_LOG=info,quickwit=info,quickwit_jaeger=debug \
cargo run --manifest-path quickwit/Cargo.toml --all-features -- run

I also checked that the field was correctly populated in the UI. Once the data model and logic are stable, I will add some unit tests.

This scope contains the collector name and version.
@guilload guilload requested a review from fmassot January 20, 2023 20:06
@guilload guilload merged commit 6f88b85 into main Jan 20, 2023
@guilload guilload deleted the guilload/fix-span-scope branch January 20, 2023 21:28
@guilload guilload added this to the Tracing milestone Jan 21, 2023
@guilload guilload linked an issue Jan 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing: instrument OTLP and Jaeger services
2 participants