-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom tokenizers ngram and regex. #3575
Conversation
3f8026c
to
ce91eb0
Compare
5b23b2d
to
0dd5aae
Compare
0b03f0c
to
a6cd4f4
Compare
@@ -38,6 +39,10 @@ pub(crate) use self::field_mapping_entry::{ | |||
FieldMappingEntryForSerialization, IndexRecordOptionSchema, QuickwitTextTokenizer, | |||
}; | |||
pub(crate) use self::field_mapping_type::FieldMappingType; | |||
pub use self::tokenizer_entry::{ | |||
analyze_text, NgramTokenizerOption, RegexTokenizerOption, TokenFilterType, TokenizerConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those public? Is it for the rest endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, only "analyze_text, TokenizerConfig, TokenizerEntry" should be public and the others should be pub(crate)
for the OpenAPI stuff.
I only had minor comments, so I approved. |
debfed6
to
bc65117
Compare
Fix #3056 and #3392
This PR adds support for custom analyzers, aka tokenizer + filters.
Doc mapping config with custom tokenizers
Endpoint to test a custom tokenizer
POST /analyze
with payload
Follow-up in PRs to come