Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate tag timestamp #3703

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

AyWa
Copy link
Collaborator

@AyWa AyWa commented Aug 2, 2023

Description

Timestamp and tag fields shouldnt start or end with dot

Fixes: #3538

How was this PR tested?

Added unit test

Co-authored-by: @sravan-s

@fmassot fmassot self-requested a review August 2, 2023 12:47
@fulmicoton fulmicoton enabled auto-merge (squash) August 3, 2023 03:00
@fulmicoton
Copy link
Contributor

thnk you!

sravan-s and others added 5 commits August 3, 2023 22:24
Timestamp and tag fields shouldnt start or end with dot
Todo: Implement tests
`//.` and `.` should end in the same way

Also address review comment about `['//.']` -> `"//."`
@sravan-s sravan-s force-pushed the feat/validate-tag-timestamp branch from a1c72cf to a5a12f0 Compare August 3, 2023 13:31
@fulmicoton fulmicoton merged commit 751fa77 into quickwit-oss:main Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation of timestamp field and tag fields in the doc mapper
3 participants