Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable request bodies decompression #4003

Conversation

etolbakov
Copy link
Collaborator

Description

enable request bodies decompression

How was this PR tested?

this setting hasn't been tested

Related issue

#3990

@etolbakov etolbakov marked this pull request as ready for review October 21, 2023 09:30
@guilload
Copy link
Member

Would you be able to test this? You could follow our getting started tuto and tweak the cURL command:
https://quickwit.io/docs/main-branch/get-started/quickstart.

@@ -152,6 +153,7 @@ pub(crate) async fn start_rest_server(
.compress_when(compression_predicate),
)
.layer(cors)
.layer(DecompressionLayer::new().gzip(true))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we support zstd as well?

@etolbakov
Copy link
Collaborator Author

etolbakov commented Oct 31, 2023

Currently warp (web framework) does not handle compressed bodies out of the box.
seanmonstar/warp#1035
Agreed with Adrien to park this for now.

@guilload
Copy link
Member

Yes, my bad. I assumed that warp is compatible with most tower-http layers, but that's no the case. Thanks for doing the discovery work.

@guilload
Copy link
Member

guilload commented Dec 4, 2023

@unpervertedkid, the best way to go about this is adding support in warp. I've looked into it, it's not too hard.

@unpervertedkid
Copy link
Contributor

@guilload Okay let me take a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants