feat(aggregators/metric): Add a top_hits aggregator (#2198) #3378
PSeitzAnnotations
7 warnings
|
an array of `Range` that is only one element:
src/snippet/mod.rs#L750
warning: an array of `Range` that is only one element
--> src/snippet/mod.rs:750:66
|
750 | assert_eq!(&collapse_overlapped_ranges(&[0..3, 1..2,]), &[0..3]);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
help: if you wanted a `Vec` that contains the entire range, try
|
750 | assert_eq!(&collapse_overlapped_ranges(&[0..3, 1..2,]), &(0..3).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 3, try
|
750 | assert_eq!(&collapse_overlapped_ranges(&[0..3, 1..2,]), &[0; 3]);
| ~~~~
|
|
an array of `Range` that is only one element:
src/snippet/mod.rs#L749
warning: an array of `Range` that is only one element
--> src/snippet/mod.rs:749:66
|
749 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..3,]), &[0..3]);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
help: if you wanted a `Vec` that contains the entire range, try
|
749 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..3,]), &(0..3).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 3, try
|
749 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..3,]), &[0; 3]);
| ~~~~
|
|
an array of `Range` that is only one element:
src/snippet/mod.rs#L748
warning: an array of `Range` that is only one element
--> src/snippet/mod.rs:748:66
|
748 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..2,]), &[0..2]);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
= note: `#[warn(clippy::single_range_in_vec_init)]` on by default
help: if you wanted a `Vec` that contains the entire range, try
|
748 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..2,]), &(0..2).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 2, try
|
748 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..2,]), &[0; 2]);
| ~~~~
|
|
you seem to use `.enumerate()` and immediately discard the index:
src/store/mod.rs#L132
warning: you seem to use `.enumerate()` and immediately discard the index
--> src/store/mod.rs:132:25
|
132 | for (_, doc) in store
| _________________________^
133 | | .iter::<TantivyDocument>(Some(&alive_bitset))
134 | | .enumerate()
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
132 ~ for doc in store
133 + .iter::<TantivyDocument>(Some(&alive_bitset))
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/aggregation/metric/top_hits.rs#L154
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/aggregation/metric/top_hits.rs:154:55
|
154 | let pattern = globbed_string_to_regex(&field)?;
| ^^^^^^ help: change this to: `field`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/core/tests.rs#L465
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/core/tests.rs:465:13
|
465 | &json_term_writer.term(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `json_term_writer.term()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/core/tests.rs#L427
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/core/tests.rs:427:13
|
427 | &json_term_writer.term(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `json_term_writer.term()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|