Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngram tokenizer now returns an error with invalid arguments. #2102

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Jun 25, 2023

Fixes #2100

@codecov-commenter
Copy link

Codecov Report

Merging #2102 (d73706d) into main (3b0cbf8) will decrease coverage by 0.02%.
The diff coverage is 98.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   94.39%   94.37%   -0.02%     
==========================================
  Files         321      321              
  Lines       60612    60646      +34     
==========================================
+ Hits        57213    57236      +23     
- Misses       3399     3410      +11     
Impacted Files Coverage Δ
src/core/segment_reader.rs 90.57% <0.00%> (ø)
src/lib.rs 99.05% <ø> (ø)
src/directory/ram_directory.rs 90.50% <100.00%> (ø)
src/indexer/segment_updater.rs 94.27% <100.00%> (-1.18%) ⬇️
src/postings/serializer.rs 98.95% <100.00%> (ø)
src/snippet/mod.rs 95.44% <100.00%> (ø)
src/tokenizer/ngram_tokenizer.rs 99.06% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmassot fmassot merged commit 212d59c into main Jun 27, 2023
@fmassot fmassot deleted the fmassot/ngram-new-should-return-error branch June 27, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgramTokenizer::new should return a result
3 participants