Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compat mode for JSON #2219

Merged
merged 1 commit into from
Oct 17, 2023
Merged

add compat mode for JSON #2219

merged 1 commit into from
Oct 17, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Oct 17, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (182f58c) 94.02% compared to head (ffa5f58) 94.03%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   94.02%   94.03%           
=======================================
  Files         327      327           
  Lines       65064    65156   +92     
=======================================
+ Hits        61178    61271   +93     
+ Misses       3886     3885    -1     
Files Coverage Δ
src/core/searcher.rs 77.98% <ø> (ø)
src/schema/document/de.rs 72.82% <100.00%> (+1.63%) ⬆️
src/schema/document/se.rs 90.70% <100.00%> (+0.01%) ⬆️
src/schema/document/mod.rs 90.00% <75.00%> (+0.07%) ⬆️
src/schema/document/existing_type_impls.rs 23.14% <57.14%> (ø)
src/schema/document/owned_value.rs 89.47% <82.60%> (+0.03%) ⬆️
src/core/json_utils.rs 97.74% <73.80%> (-0.40%) ⬇️
src/fastfield/writer.rs 92.41% <77.00%> (-0.39%) ⬇️
src/schema/document/value.rs 53.20% <47.88%> (+24.23%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PSeitz PSeitz merged commit ecb9a89 into main Oct 17, 2023
5 checks passed
@PSeitz PSeitz deleted the format_compat branch October 17, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants