add Key::I64 and Key::U64 variants in aggregation #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all `Key` numerical values are returned as f64. This causes problems in some cases with the precision and the way f64 is serialized. This PR adds `Key::I64` and `Key::U64` variants and uses them in the term aggregation.
PSeitz
force-pushed
the
fix_f64_truncation
branch
from
2d3b27f
to
5def996
Compare
fulmicoton
reviewed
Jul 31, 2024
| @@ -339,9 +341,18 @@ fn get_missing_val( | |||
| Key::Str(_) if column_type == ColumnType::Str => Some(u64::MAX), | |||
| // Allow fallback to number on text fields | |||
| Key::F64(_) if column_type == ColumnType::Str => Some(u64::MAX), | |||
| Key::U64(_) if column_type == ColumnType::Str => Some(u64::MAX), | |||
There was a problem hiding this comment.
I don't understand what get_missing_val is about.
It is clearly doing something strange. Do you remember?
Can you comment/rename to make it make sense?
There was a problem hiding this comment.
yes, there is definitely a comment missing to explain it
/// Get the missing value as internal u64 representation
///
/// For terms we use u64::MAX as sentinel value
/// For numerical data we convert the value into the representation
/// we would get from the fast field, when we open it as u64_lenient_for_type.
///
/// That way we can use it the same way as if it would come from the fastfield.
fulmicoton
reviewed
Jul 31, 2024
| @@ -191,6 +191,12 @@ impl SegmentCardinalityCollector { | |||
| let val = f64_to_u64(*val); | |||
| self.cardinality.sketch.insert_any(&val); | |||
| } | |||
| Key::U64(val) => { | |||
There was a problem hiding this comment.
sorry for using this PR..
.expect("Found placeholder term_ord but missing is None");
I think we are just supposed to ignore the value.
fulmicoton
approved these changes
Jul 31, 2024
PSeitz
force-pushed
the
fix_f64_truncation
branch
from
8e6df52
to
fff15c5
Compare
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
* add Key::I64 and Key::U64 variants in aggregation Currently all `Key` numerical values are returned as f64. This causes problems in some cases with the precision and the way f64 is serialized. This PR adds `Key::I64` and `Key::U64` variants and uses them in the term aggregation. * add clarification comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all
Keynumerical values are returned as f64. This causes problems in somecases with the precision and the way f64 is serialized.
This PR adds
Key::I64andKey::U64variants and uses them in the termaggregation.
Fixes quickwit-oss/quickwit#5254