Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make find_field_with_default return json fields without path #2476

Merged
merged 2 commits into from
Aug 19, 2024
Merged

make find_field_with_default return json fields without path #2476

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999d9b3
make find_field_with_default return json fields without path
trinity-1686a Aug 13, 2024
8dd0669
add tests for find_field_with_default
trinity-1686a Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/schema/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ impl Schema {
.or(default_field_opt.map(|field| (field, full_path)))?;
let field_entry = self.get_field_entry(field);
let is_json = field_entry.field_type().value_type() == Type::Json;
if is_json == json_path.is_empty() {
if !is_json && !json_path.is_empty() {
return None;
}
Some((field, json_path))
Expand Down
Loading