Improve QUIC defragmentation of TLS packets. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids excessive persistent memory usage associated with every QUIC connection, by avoiding a large (21k) preallocation of a buffer used for defragmentation of TLS packets. Instead of preallocating space for all TLS data, this only stores TLS fragments that cannot be fully assembled on the connection.
|
@bwelling would you like to adjust this to use variable length arrays as your comment suggests? (Also we can take it on quictls/quictls, but I can do the mechanics of that) |
|
I'm not sure what comment you mean, as in #158, I said
I've never used C VLAs, and I don't know exactly what you're looking for, so I'd (still) rather someone who does know do it. |
|
Sorry, I was imprecise and meant flexible array members as the comment indicates would be preferable. |
wbl
added a commit
to quictls/quictls
that referenced
this pull request
Sep 25, 2024
4 tasks
wbl
added a commit
to quictls/quictls
that referenced
this pull request
Sep 25, 2024
Based on quictls/openssl#173 Try 2 at CI: hoping windows sporadic
wbl
added a commit
to quictls/quictls
that referenced
this pull request
Sep 26, 2024
Based on quictls/openssl#173 Try 2 at CI: hoping windows sporadic
wbl
added a commit
to quictls/quictls
that referenced
this pull request
Sep 27, 2024
Based on quictls/openssl#173 Try 2 at CI: hoping windows sporadic
wbl
added a commit
to quictls/quictls
that referenced
this pull request
Sep 27, 2024
Based on quictls/openssl#173 Try 2 at CI: hoping windows sporadic
wbl
added a commit
to quictls/quictls
that referenced
this pull request
Oct 1, 2024
Based on quictls/openssl#173 Try 2 at CI: hoping windows sporadic
PauloFCP1
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids excessive persistent memory usage associated with every QUIC connection, by avoiding a large (21k) preallocation of a buffer used for defragmentation of TLS packets.
Instead of preallocating space for all TLS data, this only stores TLS fragments that cannot be fully assembled on the connection.
This replaces #158.