-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'A' Column not shown when it is blank #35
Comments
Oh man, thanks for reporting this! My first guess is that this is a rendering issue with SlickGrid, but the column sizes are given by SheetJS. Does this happen exclusively in sheets where all the first column cells are empty? Or is the first column resized as well? I'll see if I can repro this tonight. |
In my test sheet, it looks like SheetJS is trying to be clever and returning a range not inclusive of the first cell/column: https://github.com/quigleyj97/jupyterlab-spreadsheet/blob/main/src/model.ts#L94 Most of the GridWidget assumes that the letter column names and column indicies are interchangable, which would be why the expected "B" column data is missing. Easiest fix is to update |
This reproduces a blank-column issue seen in issue #35
I am not sure if this is a SheetJS or SlickGrid thing, or possibly your wrapper?
But if the 'A' Column is blank it is not shown.
It's not a big deal but it is weird when you always expect an Excel sheet to show columns A through M and rows 1 to N?
The plugin is awesome btw congrats and thanks. If this is an easy fix and if it's easy for me to get my head around your code, I could potentially submit a PR.
The text was updated successfully, but these errors were encountered: