Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 do not create quilt package on failure quilt laronde #105

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Changelog

## UNRELEASED
## [0.4.3] UNRELEASED

- Do not publish Quilt package unless workflow succeeds
- [or the metadata specifies &force=true]

## [0.4.2] 2023-07-02

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ From the command-line, do, e.g.:

```bash
# export NXF_VER=23.04.0
export NXF_PLUGINS_TEST_REPOSITORY=https://github.com/quiltdata/nf-quilt/releases/download/0.4.2/nf-quilt-0.4.2-meta.json
nextflow run main.nf -plugins [email protected].2
export NXF_PLUGINS_TEST_REPOSITORY=https://github.com/quiltdata/nf-quilt/releases/download/0.4.3/nf-quilt-0.4.3-meta.json
nextflow run main.nf -plugins [email protected].3
```

For Tower, you can use the "Pre-run script" to set the environment variables.
Expand All @@ -112,7 +112,7 @@ in order to customize the behavior of the plugin:

* Query Parameters: also stored as package-level metadata
* **msg**: specify the commit message to use when saving the package
* **readme**: specify a string for the package README
* **readme**: specify a string for the package README
(will substitute "${variables}")
* **_any other key_**: specify any other metadata key to store in the package

Expand Down
1 change: 1 addition & 0 deletions plugins/nf-quilt/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ dependencies {
compileOnly 'org.slf4j:slf4j-simple:2.0.7'
compileOnly 'black.ninia:jep:4.1.1'
runtime 'black.ninia:jep:4.1.1'
runtimeOnly 'org.junit.platform:junit-platform-launcher:1.9.3'
implementation 'black.ninia:jep:4.1.1'
testImplementation 'black.ninia:jep:4.1.1'
//testImplementation(testFixtures('black.ninia:jep:4.0.3'))
Expand Down
6 changes: 5 additions & 1 deletion plugins/nf-quilt/src/main/nextflow/quilt/QuiltProduct.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ class QuiltProduct {
this.msg = pkg.toString()
this.meta = [pkg: msg, time_start: now()]
this.session = session
publish()
if (session.isSuccess() || pkg.is_force()) {
publish()
} else {
log.info("not publishing: ${pkg} [unsuccessful session]")
}
}

String readme() {
Expand Down
2 changes: 1 addition & 1 deletion plugins/nf-quilt/src/resources/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Plugin-Class: nextflow.quilt.QuiltPlugin
Plugin-Id: nf-quilt
Plugin-Version: 0.4.2
Plugin-Version: 0.4.3
Plugin-Provider: Quilt Data
Plugin-Requires: >=22.10.6

Loading