Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fn visibility to reduce MSRV from 1.74 to 1.66 #47

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Jan 29, 2024

Thanks a lot for publishing 0.9.0!

That version has an issue that makes it require rust 1.74 - on earlier versions the build fails with:

error[E0446]: crate-private type EventFd in public interface
--> src/run.rs:49:1
|
31 | pub(crate) struct EventFd(pub(crate) Arc);
| ------------------------- EventFd declared as crate-private
...
49 | pub fn run(context: Arc, setmap: SetMap, max_length: usize, receiver: Receiver, evt_fd: EventFd) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak crate-private type

This PR lowers the MSRV to 1.66 (where std::os::fd was introduced) - if possible it would be nice with a 0.9.1 including it!

@quininer quininer merged commit 8340871 into quininer:master Jan 30, 2024
@quininer
Copy link
Owner

Thank you!

@fornwall fornwall deleted the fix-visibility branch January 30, 2024 08:11
@fornwall
Copy link
Contributor Author

Thanks yourself for the speedy 0.9.1 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants