Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more dbNSFP fields annotated by VEP #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a113n
Copy link

@a113n a113n commented Jan 14, 2017

With reference to the PR in brentp/geneimpacts#12

@brentp
Copy link
Member

brentp commented Jan 19, 2017

sorry for the delay in answering.

@a113n thanks for these changes, but, I won't accept until the arey are optional. This adds a bunch of fields to the database even when those fields might not be present in the VCF.

The advantage of this over the existing method that @matthdsm mentions is that these are typed values whereas the current method sets all VEP extra's to TEXT.

I think a better strategy might be to add a --numerics argument that will accept a list of column names and force all of those to be sql.Float().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants