CTM-ETM coupling: final changes #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kndehaan
reviewed
Aug 29, 2024
...ndustry_metal_other/external_coupling_industry_metal_other_metals_external_coupling_share.ad
Outdated
Show resolved
Hide resolved
kndehaan
reviewed
Aug 29, 2024
...l_coupling/industry_metal_other/external_coupling_industry_other_metals_electricity_share.ad
Show resolved
Hide resolved
kndehaan
requested changes
Aug 29, 2024
|
@kndehaan I picked up your requested changes and updated the Excel. Could you please verify my work? |
kndehaan
approved these changes
Aug 29, 2024
mabijkerk
force-pushed
the
ctm-etm-coupling-final
branch
from
3e253b8
to
7b24b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes final improvements for the CTM-ETM coupling improvements done in #3095. Specifically, this simplifies a number of external coupling queries and makes them more robust. It focuses on updating the inputs for setting the demand in the other metals, aluminium, food, paper and other industry sector.
To do:
Goes with: