Skip to content

Commit

Permalink
Increase default viewport size
Browse files Browse the repository at this point in the history
1920x1080 is the most popular screen resolution in the world right now,
used by about 25% of desktop computers. We don't have hard data, but we
know that majority of users interact with UI on their computers. And
since on default Playwright viewport there's an issue with dropdown items
sometimes appearing outside of viewport, bumping window size sounds like
obvious thing to do.
  • Loading branch information
mirekdlugosz committed Oct 3, 2024
1 parent 915059c commit 1270c77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion camayoc/tests/qpc/ui/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def pytest_exception_interact(node, call, report):

@pytest.fixture(scope="session")
def browser_context_args(browser_context_args):
extra_context_args = {}
extra_context_args = {"viewport": {"width": 1920, "height": 1080}}
verify_ssl = settings.quipucords_server.ssl_verify
if not verify_ssl:
extra_context_args["ignore_https_errors"] = True
Expand Down

0 comments on commit 1270c77

Please sign in to comment.