Revert "Check that scan is running before checking if it finished" #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 527a7d5, which was a part of PR #432 .
The risk I saw turned out to be true - since this commit was merged, all pipeline runs have one or two failed tests. Earlier we had failures only once in couple of runs.
From what I see, usually the problem is that we expect scan to be running, but it is already completed. It doesn't sound right - looks like scans complete in just few seconds. I find it more likely that we check wrong scan, before it even started.
But either way, we need to go back to drawing board and think about this problem a little more. I'll create a jira ticket, as this turns out to require more time.