Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Check that scan is running before checking if it finished" #433

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

mirekdlugosz
Copy link
Collaborator

This reverts commit 527a7d5, which was a part of PR #432 .

The risk I saw turned out to be true - since this commit was merged, all pipeline runs have one or two failed tests. Earlier we had failures only once in couple of runs.

From what I see, usually the problem is that we expect scan to be running, but it is already completed. It doesn't sound right - looks like scans complete in just few seconds. I find it more likely that we check wrong scan, before it even started.

But either way, we need to go back to drawing board and think about this problem a little more. I'll create a jira ticket, as this turns out to require more time.

@mirekdlugosz mirekdlugosz requested review from a team August 28, 2023 10:52
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #433 (aecacc1) into main (527a7d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   79.11%   79.11%           
=======================================
  Files           5        5           
  Lines         249      249           
=======================================
  Hits          197      197           
  Misses         52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@infinitewarp infinitewarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 🍀 🙏

@mirekdlugosz mirekdlugosz merged commit 8f59310 into main Aug 28, 2023
8 checks passed
@infinitewarp infinitewarp deleted the revert-527a7d549b branch July 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants