Introduce (pr|nightly)_only markers, split out UI tests that can use scans fixture #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 78.13% 78.20% +0.06%
==========================================
Files 7 7
Lines 677 679 +2
==========================================
+ Hits 529 531 +2
Misses 148 148 ☔ View full report in Codecov by Sentry. |
infinitewarp
approved these changes
Jun 27, 2024
Builds foundation for DISCOVERY-628. The idea is that you can mark tests to execute only in PR run or only in nightly run. Or, consequently, to NOT execute in PR / nightly run. Tests not marked with either are executed in both pipelines. The actual implementation of marker-based selection is in discovery-ci.
cleaning_data_provider is module-scoped fixture that runs data_provider.cleanup() before executing test. This ensures that test operates on empty database. UI tests used to have their own data_provider which did exactly that. However, not all UI tests require clean state - in fact, we want to introduce UI tests that use shared scan results cache. Also, not only UI tests can benefit from operating against a clean state. All tests that use that fixture are executed at the very beginning of test run. This is done to minimize time spent removing things from Discovery.
Introduce UI tests that take advantage of cached scans result and download scans that already exist. They are very similar to existing end to end tests. The intent is that new scan tests are going to run only in PR check, to speed things up. Old end to end tests are going to be run in nightly pipeline, where execution speed is less of a concern. Since new scan tests are very much included in old end to end tests, only one of them should be executed in any given run.
mirekdlugosz
force-pushed
the
use-scans-in-ui
branch
from
321a4e5
to
75ab416
Compare
ruda
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
pr_onlyandnightly_onlypytest markers, which allows tests to be marked for execution on PR job or nightly job. Tests not marked with either will be run in both.With that as a foundation, split out UI end to end test into UI scan test that takes advantage of
scansfixture and downloads a scan result created earlier for API/CLI report tests. These new scan tests are marked for PR job execution only. This should speed up PR test execution by few minutes.UI tests used their own
data_providerfixture that cleaned things up before running a test, to work around DISCOVERY-162. Since new scan tests depend on data being kept around, introduce newcleaning_data_providerthat does the same thing. All tests using that fixture are moved to the beginning of test run. Changed few other tests runningqpc clear --allto use this new fixture, or they would end up removing data that scan UI tests depended on.Actual filtering out of tests marked with new markers is implemented in discovery-ci PR 85.