-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow read-only "auth_type" attribute on credential API response #540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
=======================================
Coverage 78.33% 78.33%
=======================================
Files 7 7
Lines 683 683
=======================================
Hits 535 535
Misses 148 148 ☔ View full report in Codecov by Sentry. |
Standalone test run with updated quipucords image and camayoc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to include actual expected value and make assertions stronger this way?
Most of the tests pass password
or ssh_keyfile
, so they do know what auth_type
value they expect to see in response.
5ecedf5
to
2469687
Compare
2469687
to
56a1ef4
Compare
I updated the regex pattern and surrounding logic to match on the specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That default is more than I asked for 😃 . Thanks!
This change supports quipucords/quipucords#2735