Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): discovery-154 pf4 table wrapper #139

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

cdcabrera
Copy link
Member

What's included

Features

  1. table discovery-154 pf4 table wrapper (d9b43c9)

Notes

  • there are no visual changes associated with this PR
  • wrapper for allowing ease of implementation when using pf4 composable table

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Example

...

Updates issue/story

DISCOVERY-154

related #106

@cdcabrera cdcabrera added the pf4 Tracking for pf4 refactors label Aug 11, 2022
@cdcabrera cdcabrera force-pushed the dis-154-tablewrapper branch 2 times, most recently from 459c44b to 0e8114f Compare August 11, 2022 21:28
@cdcabrera cdcabrera marked this pull request as ready for review August 11, 2022 21:29
* table, pf4 composable wrapper
* tableEmpty, empty results placeholder
* tableHelpers, generate props, data parse
@cdcabrera cdcabrera merged commit 306781a into quipucords:dev Aug 12, 2022
cdcabrera added a commit that referenced this pull request Aug 12, 2022
* table, pf4 composable wrapper
* tableEmpty, empty results placeholder
* tableHelpers, generate props, data parse
cdcabrera added a commit that referenced this pull request Sep 7, 2022
* table, pf4 composable wrapper
* tableEmpty, empty results placeholder
* tableHelpers, generate props, data parse
cdcabrera added a commit that referenced this pull request Sep 8, 2022
* table, pf4 composable wrapper
* tableEmpty, empty results placeholder
* tableHelpers, generate props, data parse
cdcabrera added a commit that referenced this pull request Sep 20, 2022
* table, pf4 composable wrapper
* tableEmpty, empty results placeholder
* tableHelpers, generate props, data parse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pf4:wrapper-component pf4 Tracking for pf4 refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant