Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(sourceWizard): convert text input fields to use PF4 component #159

Merged
merged 2 commits into from
Sep 14, 2022
Merged

cleanup(sourceWizard): convert text input fields to use PF4 component #159

merged 2 commits into from
Sep 14, 2022

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Sep 8, 2022 •
edited
Loading

What's included

Towards #104 : TextInput - extends #149, #150

Converts remaining PF3 Form Fields in addSourceWizard

Example

Before

Screen Shot 2022-09-08 at 3 30 52 PM

After

Screen Shot 2022-09-08 at 3 15 01 PM

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #159 (9617b1a) into dev-forms (13496d9) will not change coverage.
The diff coverage is n/a.

❗ Current head 9617b1a differs from pull request most recent head bee080f. Consider uploading reports for the commit bee080f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           dev-forms     #159   +/-   ##
==========================================
  Coverage      78.99%   78.99%           
==========================================
  Files            109      109           
  Lines           3575     3575           
  Branches        1131     1131           
==========================================
  Hits            2824     2824           
  Misses           656      656           
  Partials          95       95
Impacted Files Coverage Δ
...mponents/addSourceWizard/addSourceWizardStepTwo.js 76.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13496d9...bee080f. Read the comment docs.

@cdcabrera cdcabrera changed the base branch from dev-forms to 20220909b-dev-forms September 9, 2022 16:29
@cdcabrera cdcabrera changed the base branch from 20220909b-dev-forms to dev-forms September 9, 2022 17:43
@cdcabrera cdcabrera added pf4 Tracking for pf4 refactors pf4: forms labels Sep 9, 2022
bclarhk
bclarhk approved these changes Sep 9, 2022
View reviewed changes
Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good

cdcabrera
cdcabrera approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cdcabrera
Copy link
Member

Adding in the fix for the textInput, similar to #158 textArea

@cdcabrera cdcabrera merged commit 303b874 into quipucords:dev-forms Sep 14, 2022
cdcabrera added a commit that referenced this pull request Sep 14, 2022
@cdcabrera
fix(textInput): discovery-151 state, callback sequence (#159)
dc57367
cdcabrera added a commit that referenced this pull request Sep 14, 2022
@cdcabrera
fix(textInput): discovery-151 state, callback sequence (#159)
d59707e
cdcabrera pushed a commit that referenced this pull request Sep 14, 2022
@jenny-s51 @cdcabrera
refactor(addSourceWizardStepTwo): discovery-153 pf4 textInput (#159)
86d6259
cdcabrera added a commit that referenced this pull request Sep 22, 2022
@cdcabrera
fix(textInput): discovery-151 state, callback sequence (#159)
4513a8c
cdcabrera pushed a commit that referenced this pull request Sep 22, 2022
@jenny-s51 @cdcabrera
refactor(addSourceWizardStepTwo): discovery-153 pf4 textInput (#159)
2927503
@cdcabrera cdcabrera mentioned this pull request Sep 22, 2022
Merged
cdcabrera added a commit that referenced this pull request Sep 26, 2022
@cdcabrera
fix(textInput): discovery-151 state, callback sequence (#159)
272e7b2
cdcabrera pushed a commit that referenced this pull request Sep 26, 2022
@jenny-s51 @cdcabrera
refactor(addSourceWizardStepTwo): discovery-153 pf4 textInput (#159)
4d31f69
cdcabrera added a commit that referenced this pull request Oct 20, 2022
@cdcabrera
fix(textInput): discovery-151 state, callback sequence (#159)
4e2012a
cdcabrera pushed a commit that referenced this pull request Oct 20, 2022
@jenny-s51 @cdcabrera
refactor(addSourceWizardStepTwo): discovery-153 pf4 textInput (#159)
d1192c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclarhk bclarhk bclarhk approved these changes

@cdcabrera cdcabrera cdcabrera approved these changes

@ruda ruda Awaiting requested review from ruda

Assignees
No one assigned
Labels
pf4: forms pf4 Tracking for pf4 refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenny-s51 @codecov-commenter @cdcabrera @bclarhk