Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sources): discovery-154, activate scans button #166

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(sources): discovery-154, activate scans button

Notes

  • makes it so 2 or more selections activate the scan button in the upper right toolbar, currently it's set for 1 or more
  • makes it consistent with the merge reports dialog on scans, and the credentials toolbar delete button

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start:stage
  3. navigate to sources and confirm it now takes 2 or more selections to activate the toolbar scans button

Example

Screen Shot 2022-09-15 at 6 55 17 PM

Updates issue/story

DISCOVERY-154

@cdcabrera cdcabrera added pf4 Tracking for pf4 refactors pf4:clean up labels Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #166 (926cadd) into dev (00a4f97) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #166   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         108      108           
  Lines        3468     3468           
  Branches     1135     1135           
=======================================
  Hits         2787     2787           
  Misses        600      600           
  Partials       81       81           
Impacted Files Coverage Δ
src/components/sources/sources.js 77.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a4f97...926cadd. Read the comment docs.

* sources, 2 or more selections, activate button
@cdcabrera cdcabrera merged commit 7875423 into quipucords:dev Sep 16, 2022
@cdcabrera cdcabrera added the bug Something isn't working label Sep 16, 2022
cdcabrera added a commit that referenced this pull request Sep 20, 2022
* sources, 2 or more selections activate button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pf4:clean up pf4 Tracking for pf4 refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants