Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): discovery-174 css font paths #170

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

cdcabrera
Copy link
Member

What's included

Bug Fixes

  1. build discovery-174 css font paths (6a4cf9e)

How to test

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm the dist output for the templates css file
    • no longer contains references to ./assets/...
    • but instead now uses /static/media/...

Example

...

Updates issue/story

DISCOVERY-174

@cdcabrera cdcabrera added bug Something isn't working pf4 Tracking for pf4 refactors labels Sep 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #170 (6a4cf9e) into master (6af0929) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   80.47%   80.47%           
=======================================
  Files         109      109           
  Lines        3473     3473           
  Branches     1144     1144           
=======================================
  Hits         2795     2795           
  Misses        595      595           
  Partials       83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af0929...6a4cf9e. Read the comment docs.

Copy link
Contributor

@bruno-fs bruno-fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waaaay better to read than the regex I proposed on server side.

I tested building locally where it was breaking. LGTM 👍

@cdcabrera cdcabrera merged commit d616dfb into master Sep 22, 2022
@cdcabrera cdcabrera deleted the build-template-css branch September 22, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pf4 Tracking for pf4 refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants