Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(viewToolbar): discovery-151 pf4 toolbar #172

Merged
merged 1 commit into from
Sep 30, 2022
Merged

refactor(viewToolbar): discovery-151 pf4 toolbar #172

merged 1 commit into from
Sep 30, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 27, 2022 •
edited
Loading

What's included

  • refactor(viewToolbar): discovery-151 pf4 toolbar

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start:stage
  3. confirm you are able to do the follow actions Sources, Scans, Credentials
    1. filter sources with either the text input, or select options
    2. clear a filter, and then clear all filters
    3. sort

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm build completes without error

Example

Before

Screen Shot 2022-09-26 at 10 52 54 AM
Screen Shot 2022-09-26 at 10 53 12 AM
Screen Shot 2022-09-26 at 10 53 38 AM
Screen Shot 2022-09-26 at 10 54 47 AM

After

Screen Shot 2022-09-26 at 10 50 18 AM
Screen Shot 2022-09-26 at 10 50 06 AM
Screen Shot 2022-09-26 at 10 49 22 AM
Screen Shot 2022-09-26 at 10 55 31 AM

Updates issue/story

DISCOVERY-151
closes #146
closes #103

@cdcabrera cdcabrera added the pf4 Tracking for pf4 refactors label Sep 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022 •
edited
Loading

Codecov Report

Merging #172 (bad91d1) into dev (aa8a2fd) will increase coverage by 1.61%.
The diff coverage is 90.35%.

❗ Current head bad91d1 differs from pull request most recent head b7e763b. Consider uploading reports for the commit b7e763b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #172      +/-   ##
==========================================
+ Coverage   81.00%   82.61%   +1.61%     
==========================================
  Files         113      118       +5     
  Lines        3611     3693      +82     
  Branches     1201     1252      +51     
==========================================
+ Hits         2925     3051     +126     
+ Misses        602      562      -40     
+ Partials       84       80       -4
Impacted Files Coverage Δ
src/components/addSourceWizard/addSourceWizard.js 85.71% <ø> (ø)
...s/createCredentialDialog/createCredentialDialog.js 35.76% <0.00%> (ø)
...rc/components/createScanDialog/createScanDialog.js 58.25% <ø> (ø)
src/redux/actions/sourcesActions.js 100.00% <ø> (ø)
src/redux/constants/index.js 100.00% <ø> (ø)
src/redux/constants/sourcesConstants.js 100.00% <ø> (ø)
src/redux/reducers/scansReducer.js 100.00% <ø> (ø)
src/components/credentials/credentialsToolbar.js 27.27% <27.27%> (ø)
src/components/scans/scansToolbar.js 27.27% <27.27%> (ø)
src/components/sources/sourcesToolbar.js 73.33% <73.33%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8a2fd...b7e763b. Read the comment docs.

cdcabrera
cdcabrera commented Sep 29, 2022
View reviewed changes
src/components/createScanDialog/createScanDialog.js Show resolved Hide resolved
src/components/credentials/credentials.js Outdated Show resolved Hide resolved
src/components/scans/scans.js Outdated Show resolved Hide resolved
src/components/sources/sources.js Outdated Show resolved Hide resolved
src/components/view/viewContext.js Show resolved Hide resolved
@cdcabrera cdcabrera force-pushed the dis-151-refactor-toolbar branch 3 times, most recently from 516ed25 to ecadd23 Compare September 29, 2022 12:44
@cdcabrera cdcabrera mentioned this pull request Sep 29, 2022
Merged
@cdcabrera
refactor(viewToolbar): discovery-151 pf4 toolbar
b7e763b 
* helpers, remove unused createViewQueryObject
* addCredentialType, locale string
* addSourceWizard, createScanDialog dispatch update
* createCredentialDialog, adjust getCredentials
* creds, scans, sourceConstants, clean up
* creds, scans, source views, pf4 toolbar
* creds, scans, sourcesContext, separate api hook
* creds, scans, sourcesToolbar, field configs
* viewContext, useQuery, useConfig, useView hooks
* viewPaginationRow, use view context
* viewToolbar, context, pf4 toolbar, allow config
* viewToolbarFieldSort, button, sorting config
* viewToolbarSelect, select config
* viewToolbarTextInput, input config
* redux, actions, reducers, constants, clean up
* build, setupTests, mock for lodash
@cdcabrera cdcabrera marked this pull request as ready for review September 29, 2022 21:38
bclarhk
bclarhk approved these changes Sep 29, 2022
View reviewed changes
Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdcabrera cdcabrera merged commit c53b0bf into quipucords:dev Sep 30, 2022
cdcabrera added a commit that referenced this pull request Oct 20, 2022
@cdcabrera
refactor(viewToolbar): discovery-151 pf4 toolbar (#172)
c2db2ff 
* helpers, remove unused createViewQueryObject
* addCredentialType, locale string
* addSourceWizard, createScanDialog dispatch update
* createCredentialDialog, adjust getCredentials
* creds, scans, sourceConstants, clean up
* creds, scans, source views, pf4 toolbar
* creds, scans, sourcesContext, separate api hook
* creds, scans, sourcesToolbar, field configs
* viewContext, useQuery, useConfig, useView hooks
* viewPaginationRow, use view context
* viewToolbar, context, pf4 toolbar, allow config
* viewToolbarFieldSort, button, sorting config
* viewToolbarSelect, select config
* viewToolbarTextInput, input config
* redux, actions, reducers, constants, clean up
* build, setupTests, mock for lodash
@cdcabrera cdcabrera mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclarhk bclarhk bclarhk approved these changes

@ruda ruda Awaiting requested review from ruda

Assignees
No one assigned
Labels
pf4 Tracking for pf4 refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdcabrera @codecov-commenter @bclarhk