Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentialsTableCells): discovery-197 auth type string #183

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 14, 2022

What's included

  • fix(credentialsTableCells): discovery-197 auth type string

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start:stage
  3. create multiple credential types
    • confirm the correct auth type string displays

Example

Screen Shot 2022-10-14 at 12 28 25 AM

Updates issue/story

DISCOVERY-197

@cdcabrera cdcabrera added bug Something isn't working pf4 Tracking for pf4 refactors labels Oct 14, 2022
@cdcabrera cdcabrera requested a review from ruda October 14, 2022 04:13
@cdcabrera cdcabrera marked this pull request as ready for review October 14, 2022 04:34
@codecov-commenter
Copy link

Codecov Report

Merging #183 (d8f5d42) into dev (bb3d7e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #183   +/-   ##
=======================================
  Coverage   82.89%   82.90%           
=======================================
  Files         115      115           
  Lines        3684     3685    +1     
  Branches     1274     1274           
=======================================
+ Hits         3054     3055    +1     
  Misses        552      552           
  Partials       78       78           
Impacted Files Coverage Δ
...rc/components/credentials/credentialsTableCells.js 75.00% <100.00%> (ø)
src/constants/apiConstants.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3d7e2...d8f5d42. Read the comment docs.

@cdcabrera cdcabrera merged commit e5aa9e0 into quipucords:dev Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pf4 Tracking for pf4 refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants