-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add delete scan function #208
feature: add delete scan function #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far. Just a couple of minor mods need to happen to align with the storyboard.
Attached some references for you and of course, as you noted, all those unit tests need to be updated.
1bfe552
to
27fce57
Compare
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 84.28% 84.12% -0.16%
==========================================
Files 116 116
Lines 3716 3761 +45
Branches 1323 1342 +19
==========================================
+ Hits 3132 3164 +32
- Misses 521 532 +11
- Partials 63 65 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I can achieve a match and functionality by using both $ yarn start
and $ yarn start:stage
I do recommend we have a double check from testing around deleting a scan that has just started. If that has already been confirmed props! (iterative works)
And finally, just need to work on the commit messaging a little. When we merge we can talk that over @nicolearagao
*locale, delete scan strings *scansService, fix deleteScan func *scansActions, add deleteScan action *scansConstants, delete scan constants *scansReducer, delete scan state *scansContext, delete scan hook *scans, delete scans props *scansTableCells, delete button
400bb82
to
ba29b7e
Compare
What's included
fix(deleteScanDialog): locale strings
feature(deleteScan): adds scan deletion functionality
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Local run check
$ yarn
$ yarn start:stage
Example
-Confirm item was deleted
Updates issue/story
feature(deleteScan): discovery-76