Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): ds-661 move to i18next-http-backend #362

Merged
merged 1 commit into from
May 7, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 3, 2024

What's included

  • build(deps): ds-661 move to i18next-http-backend

Notes

  • moves from the deprecated i18next support package to the newer version

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the EN locale is loading... does copy display
    • if copy doesn't load this update is broken...

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

DISCOVERY-661
blocked by #349

@cdcabrera cdcabrera added the build label May 3, 2024
@cdcabrera cdcabrera changed the title WIP build(deps): ds-661 move to i18next-http-backend build(deps): ds-661 move to i18next-http-backend May 6, 2024
@cdcabrera cdcabrera marked this pull request as ready for review May 6, 2024 17:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (3d66168) to head (7f1ed93).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   84.19%   84.07%   -0.13%     
==========================================
  Files         116      116              
  Lines        3783     3798      +15     
  Branches     1345     1349       +4     
==========================================
+ Hits         3185     3193       +8     
- Misses        537      544       +7     
  Partials       61       61              
Files Coverage Δ
src/components/i18n/i18n.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8776248...7f1ed93. Read the comment docs.

Copy link
Member

@nicolearagao nicolearagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all is working well

@cdcabrera cdcabrera merged commit f8815d1 into quipucords:main May 7, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants