fix(viewToolbar): dsc-682 add missing types to filter #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credential type and Source type filter items were missing RHACS and Ansible. Add them. Relates to JIRA: DISCOVERY-682 https://issues.redhat.com/browse/DISCOVERY-682
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 84.19% 84.24% +0.05%
==========================================
Files 116 116
Lines 3783 3765 -18
Branches 1345 1341 -4
==========================================
- Hits 3185 3172 -13
+ Misses 537 533 -4
+ Partials 61 60 -1
Continue to review full report in Codecov by Sentry.
|
bruno-fs
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential type and Source type filter items were missing RHACS and Ansible. We must have forgot to add them back when we introduced these source types. Add these items now.
Relates to JIRA: DISCOVERY-682