DS-680 hooks/useSearchParam #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
reviewed
Jun 18, 2024
There was a problem hiding this comment.
The useSearchParam hook is an unused leftover. Unclear what a passive read of the browser level querystring was intended for in this application ui.
The v1 code also doesn't have something like this so we should feel comfortable removing it for now and then if we have to we can pull it back. Keep your branch around
nicolearagao
force-pushed
the
ds-680-SearchParam
branch
from
06e3459
to
6811691
Compare
Relates to JIRA: DISCOVERY-680
nicolearagao
force-pushed
the
ds-680-SearchParam
branch
from
6811691
to
08ae609
Compare
cdcabrera
approved these changes
Jul 17, 2024
cdcabrera
pushed a commit
to cdcabrera/quipucords-ui
that referenced
this pull request
Jul 17, 2024
Relates to JIRA: DISCOVERY-680
cdcabrera
pushed a commit
to cdcabrera/quipucords-ui
that referenced
this pull request
Jul 18, 2024
Relates to JIRA: DISCOVERY-680
cdcabrera
pushed a commit
to cdcabrera/quipucords-ui
that referenced
this pull request
Jul 18, 2024
Relates to JIRA: DISCOVERY-680
cdcabrera
pushed a commit
to cdcabrera/quipucords-ui
that referenced
this pull request
Jul 23, 2024
Relates to JIRA: DISCOVERY-680
cdcabrera
pushed a commit
to cdcabrera/quipucords-ui
that referenced
this pull request
Jul 23, 2024
Relates to JIRA: DISCOVERY-680
cdcabrera
pushed a commit
that referenced
this pull request
Jul 25, 2024
Relates to JIRA: DISCOVERY-680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
refactor: ds-680 remove unused hooks/useSearchParam
How to test
Coverage and basic unit test check
$ npm install$ npm testInteractive unit test check
$ npm install$ npm run test:watchLocal run check
$ npm install$ npm run startCheck the build
$ npm install$ npm run buildUpdates issue/story
DISCOVERY-680